X-Git-Url: http://jsfdemo.indexdata.com/?a=blobdiff_plain;f=src%2Fclient.c;h=30ef0407b4b25f0c4b7cdd0d4791209d3382d70b;hb=5b6b18f35bb161eafa6f8a8bd0413a35ce637eff;hp=efdd7cd0edd5c4bea4c7a40b4e3bee2ec8fd4d86;hpb=ee3cced3e5eaa2a3790a6b4ebd025843a3adcc37;p=pazpar2-moved-to-github.git diff --git a/src/client.c b/src/client.c index efdd7cd..30ef040 100644 --- a/src/client.c +++ b/src/client.c @@ -18,7 +18,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ /** \file client.c - \brief Z39.50 client + \brief Z39.50 client */ #if HAVE_CONFIG_H @@ -286,7 +286,7 @@ int client_show_raw_begin(struct client *cl, int position, if (!cl->connection) return -1; - + rr = xmalloc(sizeof(*rr)); rr->position = position; @@ -306,13 +306,13 @@ int client_show_raw_begin(struct client *cl, int position, assert(nativesyntax); rr->nativesyntax = xstrdup(nativesyntax); - + rr->next = 0; - + for (rrp = &cl->show_raw; *rrp; rrp = &(*rrp)->next) ; *rrp = rr; - + if (cl->state == Client_Failed) { client_show_raw_error(cl, "client failed"); @@ -533,7 +533,7 @@ void client_search_response(struct client *cl) ZOOM_resultset resultset = cl->resultset; const char *error, *addinfo = 0; - + if (ZOOM_connection_error(link, &error, &addinfo)) { cl->hits = 0; @@ -593,7 +593,7 @@ static void client_record_ingest(struct client *cl) NMEM nmem = nmem_create(); const char *xmlrec; char type[80]; - + const char *s = session_setting_oneval(sdb, PZ_NATIVESYNTAX); if (nativesyntax_to_type(s, type, rec)) yaz_log(YLOG_WARN, "Failed to determine record type"); @@ -615,8 +615,7 @@ static void client_record_ingest(struct client *cl) } else { - yaz_log(YLOG_WARN, "Expected record, but got NULL, offset=%d", - offset); + yaz_log(YLOG_WARN, "Expected record, but got NULL, offset=%d", offset); } } @@ -673,7 +672,7 @@ static void client_set_facets_request(struct client *cl, ZOOM_connection link) struct session_database *sdb = client_get_database(cl); WRBUF w = wrbuf_alloc(); - + struct setting *s; for (s = sdb->settings[PZ_FACETMAP]; s; s = s->next) @@ -717,7 +716,7 @@ static const char *get_strategy_plus_sort(struct client *l, const char *field) struct setting *s; const char *strategy_plus_sort = 0; - + for (s = sdb->settings[PZ_SORTMAP]; s; s = s->next) { char *p = strchr(s->name + 3, ':'); @@ -753,7 +752,7 @@ void client_start_search(struct client *cl) const char *opt_preferred = session_setting_oneval(sdb, PZ_PREFERRED); const char *extra_args = session_setting_oneval(sdb, PZ_EXTRA_ARGS); const char *opt_present_chunk = session_setting_oneval(sdb, PZ_PRESENT_CHUNK); - ZOOM_query q; + ZOOM_query query; char maxrecs_str[24], startrecs_str[24], present_chunk_str[24]; int present_chunk = 20; // Default chunk size if (opt_present_chunk && strcmp(opt_present_chunk,"")) { @@ -814,26 +813,26 @@ void client_start_search(struct client *cl) /* facets definition is in PQF */ client_set_facets_request(cl, link); - q = ZOOM_query_create(); + query = ZOOM_query_create(); if (cl->cqlquery) { yaz_log(YLOG_LOG, "Client %s: Search CQL: %s", client_get_id(cl), cl->cqlquery); - ZOOM_query_cql(q, cl->cqlquery); + ZOOM_query_cql(query, cl->cqlquery); if (*opt_sort) - ZOOM_query_sortby(q, opt_sort); + ZOOM_query_sortby(query, opt_sort); } else { yaz_log(YLOG_LOG, "Client %s: Search PQF: %s", client_get_id(cl), cl->pquery); - - ZOOM_query_prefix(q, cl->pquery); + + ZOOM_query_prefix(query, cl->pquery); } if (se->sorted_results) { /* first entry is current sorting ! */ const char *sort_strategy_and_spec = - get_strategy_plus_sort(cl, se->sorted_results->field); + get_strategy_plus_sort(cl, se->sorted_results->name); int increasing = se->sorted_results->increasing; - int position = se->sorted_results->position; + // int position = se->sorted_results->type; if (sort_strategy_and_spec && strlen(sort_strategy_and_spec) < 40) { char spec[50], *p; @@ -849,17 +848,17 @@ void client_start_search(struct client *cl) else strcat(p, " >"); yaz_log(YLOG_LOG, "Client %s: applying sorting %s %s", client_get_id(cl), spec, p); - ZOOM_query_sortby2(q, spec, p); + ZOOM_query_sortby2(query, spec, p); } } else { - /* no native sorting.. If this is not the first search, then - skip it entirely */ + /* no native sorting.. If this is not the first search, then skip it entirely */ if (se->sorted_results->next) { + // TODO this seems wrong. Need to re-ingest instead? yaz_log(YLOG_DEBUG,"Client %s: Do not (re)search anyway", client_get_id(cl)); - ZOOM_query_destroy(q); + ZOOM_query_destroy(query); return; } } @@ -868,8 +867,8 @@ void client_start_search(struct client *cl) client_set_state(cl, Client_Working); cl->hits = 0; cl->record_offset = 0; - rs = ZOOM_connection_search(link, q); - ZOOM_query_destroy(q); + rs = ZOOM_connection_search(link, query); + ZOOM_query_destroy(query); ZOOM_resultset_destroy(cl->resultset); cl->resultset = rs; connection_continue(co); @@ -902,7 +901,7 @@ struct client *client_create(const char *id) assert(id); cl->id = xstrdup(id); client_use(1); - + return cl; } @@ -994,15 +993,33 @@ static CCL_bibset prepare_cclmap(struct client *cl, CCL_bibset base_bibset) res = ccl_qual_mk(); for (s = sdb->settings[PZ_CCLMAP]; s; s = s->next) { + const char *addinfo = 0; char *p = strchr(s->name + 3, ':'); if (!p) { - yaz_log(YLOG_WARN, "Malformed cclmap name: %s", s->name); + WRBUF w = wrbuf_alloc(); + wrbuf_printf(w, "Malformed cclmap. name=%s", s->name); + yaz_log(YLOG_WARN, "%s: %s", client_get_id(cl), wrbuf_cstr(w)); + client_set_diagnostic(cl, ZOOM_ERROR_CCL_CONFIG, wrbuf_cstr(w)); + client_set_state_nb(cl, Client_Error); ccl_qual_rm(&res); + wrbuf_destroy(w); return 0; } p++; - ccl_qual_fitem(res, s->value, p); + if (ccl_qual_fitem2(res, s->value, p, &addinfo)) + { + WRBUF w = wrbuf_alloc(); + + wrbuf_printf(w, "Malformed cclmap. name=%s: value=%s (%s)", + s->name, p, addinfo); + yaz_log(YLOG_WARN, "%s: %s", client_get_id(cl), wrbuf_cstr(w)); + client_set_diagnostic(cl, ZOOM_ERROR_CCL_CONFIG, wrbuf_cstr(w)); + client_set_state_nb(cl, Client_Error); + ccl_qual_rm(&res); + wrbuf_destroy(w); + return 0; + } } return res; } @@ -1022,7 +1039,7 @@ static char *make_cqlquery(struct client *cl, Z_RPNQuery *zquery) else { r = xstrdup(wrbuf_cstr(wrb)); - } + } wrbuf_destroy(wrb); cql_transform_close(cqlt); return r; @@ -1036,7 +1053,7 @@ static char *make_solrquery(struct client *cl, Z_RPNQuery *zquery) char *r = 0; WRBUF wrb = wrbuf_alloc(); int status; - + if ((status = solr_transform_rpn2solr_wrbuf(sqlt, wrb, zquery))) { yaz_log(YLOG_WARN, "Failed to generate SOLR query, code=%d", status); @@ -1060,7 +1077,7 @@ const char *client_get_facet_limit_local(struct client *cl, for (; (name = facet_limits_get(cl->facet_limits, *l, &value)); (*l)++) { struct setting *s = 0; - + for (s = sdb->settings[PZ_LIMITMAP]; s; s = s->next) { const char *p = strchr(s->name + 3, ':'); @@ -1070,7 +1087,7 @@ const char *client_get_facet_limit_local(struct client *cl, const char *cp = s->value + 6; while (*cp == ' ') cp++; - + nmem_strsplit_escape2(nmem, "|", value, values, num, 1, '\\', 1); (*l)++; @@ -1083,17 +1100,12 @@ const char *client_get_facet_limit_local(struct client *cl, static int apply_limit(struct session_database *sdb, facet_limits_t facet_limits, - WRBUF w_pqf, WRBUF w_ccl, - CCL_bibset ccl_map) + WRBUF w_pqf, CCL_bibset ccl_map) { int ret = 0; int i = 0; const char *name; const char *value; - const char **and_op_names = ccl_qual_search_special(ccl_map, "and"); - const char *and_op = and_op_names ? and_op_names[0] : "and"; - const char **or_op_names = ccl_qual_search_special(ccl_map, "or"); - const char *or_op = or_op_names ? or_op_names[0] : "or"; NMEM nmem_tmp = nmem_create(); for (i = 0; (name = facet_limits_get(facet_limits, i, &value)); i++) @@ -1128,20 +1140,34 @@ static int apply_limit(struct session_database *sdb, else if (!strncmp(s->value, "ccl:", 4)) { const char *ccl = s->value + 4; - - wrbuf_printf(w_ccl, " %s (", and_op); - + WRBUF ccl_w = wrbuf_alloc(); for (i = 0; i < num; i++) { - if (i) - wrbuf_printf(w_ccl, " %s ", or_op); - wrbuf_puts(w_ccl, ccl); - wrbuf_puts(w_ccl, "=\""); - wrbuf_puts(w_ccl, values[i]); - wrbuf_puts(w_ccl, "\""); + int cerror, cpos; + struct ccl_rpn_node *cn; + + wrbuf_rewind(ccl_w); + wrbuf_puts(ccl_w, ccl); + wrbuf_puts(ccl_w, "=\""); + wrbuf_puts(ccl_w, values[i]); + wrbuf_puts(ccl_w, "\""); + + cn = ccl_find_str(ccl_map, wrbuf_cstr(ccl_w), + &cerror, &cpos); + if (cn) + { + if (i == 0) + wrbuf_printf(w_pqf, "@and "); + + /* or multiple values.. could be bad if last CCL + parse fails, but this is unlikely to happen */ + if (i < num - 1) + wrbuf_printf(w_pqf, "@or "); + ccl_pquery(w_pqf, cn); + ccl_rpn_delete(cn); + } } - wrbuf_puts(w_ccl, ")"); - + wrbuf_destroy(ccl_w); } else if (!strncmp(s->value, "local:", 6)) { /* no operation */ @@ -1164,7 +1190,7 @@ static int apply_limit(struct session_database *sdb, nmem_destroy(nmem_tmp); return ret; } - + // Parse the query given the settings specific to this client // return 0 if query is OK but different from before // return 1 if query is OK but same as before @@ -1190,7 +1216,7 @@ int client_parse_query(struct client *cl, const char *query, Z_RPNQuery *zquery; if (!ccl_map) - return -1; + return -3; if (maxrecs && atoi(maxrecs) != cl->maxrecs) { @@ -1214,7 +1240,7 @@ int client_parse_query(struct client *cl, const char *query, wrbuf_puts(w_pqf, " "); } - if (apply_limit(sdb, facet_limits, w_pqf, w_ccl, ccl_map)) + if (apply_limit(sdb, facet_limits, w_pqf, ccl_map)) { ccl_qual_rm(&ccl_map); return -2; @@ -1266,11 +1292,11 @@ int client_parse_query(struct client *cl, const char *query, ret_value = 0; } wrbuf_destroy(w_pqf); - + xfree(cl->cqlquery); cl->cqlquery = 0; - odr_out = odr_createmem(ODR_ENCODE); + odr_out = odr_createmem(ODR_ENCODE); zquery = p_query_rpn(odr_out, cl->pquery); if (!zquery) { @@ -1283,7 +1309,7 @@ int client_parse_query(struct client *cl, const char *query, { session_log(se, YLOG_LOG, "PQF for Client %s: %s", client_get_id(cl), cl->pquery); - + /* Support for PQF on SRU targets. */ if (strcmp(query_syntax, "pqf") != 0 && *sru) { @@ -1301,7 +1327,11 @@ int client_parse_query(struct client *cl, const char *query, if (!se->relevance) { // Initialize relevance structure with query terms - se->relevance = relevance_create_ccl(se->service->charsets, cn); + se->relevance = relevance_create_ccl(se->service->charsets, cn, + se->service->rank_cluster, + se->service->rank_follow, + se->service->rank_lead, + se->service->rank_length); } ccl_rpn_delete(cn); return ret_value; @@ -1467,6 +1497,11 @@ static void client_suggestions_destroy(struct client *cl) nmem_destroy(nmem); } +int client_test_sort_order(struct client *cl, struct reclist_sortparms *sp) +{ + //TODO implement correctly. + return 1; +} /* * Local variables: * c-basic-offset: 4