X-Git-Url: http://jsfdemo.indexdata.com/?a=blobdiff_plain;f=src%2Fclient.c;h=9cb51409633e8b37c013d79cb6e2a83ab3f5a43c;hb=142c8c510a7b23c633272c656e45277e4ec35d30;hp=1f8de6d8803adcb027f072216d16cb398d7ea8fd;hpb=b279c57c3356794d6d0d5c542e044851fb3cd0ae;p=pazpar2-moved-to-github.git diff --git a/src/client.c b/src/client.c index 1f8de6d..9cb5140 100644 --- a/src/client.c +++ b/src/client.c @@ -34,14 +34,7 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #if HAVE_UNISTD_H #include #endif -#if HAVE_SYS_SOCKET_H -#include -#endif -#if HAVE_NETDB_H -#include -#endif #include -#include #include #include @@ -65,10 +58,6 @@ Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA #include #endif -#if HAVE_NETINET_IN_H -#include -#endif - #include "pazpar2.h" #include "client.h" @@ -83,9 +72,7 @@ struct client { char *pquery; // Current search char *cqlquery; // used for SRU targets only int hits; - int records; - int setno; - int requestid; // ID of current outstanding request + int record_offset; int diagnostic; enum client_state state; struct show_raw *show_raw; @@ -106,16 +93,11 @@ struct show_raw { static const char *client_states[] = { "Client_Connecting", - "Client_Connected", "Client_Idle", - "Client_Initializing", - "Client_Searching", - "Client_Presenting", + "Client_Working", "Client_Error", "Client_Failed", - "Client_Disconnected", - "Client_Stopped", - "Client_Continue" + "Client_Disconnected" }; static struct client *client_freelist = 0; @@ -146,7 +128,6 @@ static void client_show_raw_error(struct client *cl, const char *addinfo); // Close connection and set state to error void client_fatal(struct client *cl) { - //client_show_raw_error(cl, "client connection failure"); yaz_log(YLOG_WARN, "Fatal error from %s", client_get_url(cl)); connection_destroy(cl->connection); client_set_state(cl, Client_Error); @@ -172,12 +153,6 @@ const char *client_get_pquery(struct client *cl) return cl->pquery; } -void client_set_requestid(struct client *cl, int id) -{ - cl->requestid = id; -} - - static void client_send_raw_present(struct client *cl); int client_show_raw_begin(struct client *cl, int position, @@ -296,7 +271,7 @@ static void client_send_raw_present(struct client *cl) connection_continue(co); } -static int nativesyntax_to_type(struct session_database *sdb, char *type) +static int nativesyntax_to_type(struct session_database *sdb, char *type, ZOOM_record rec) { const char *s = session_setting_oneval(sdb, PZ_NATIVESYNTAX); @@ -313,10 +288,27 @@ static int nativesyntax_to_type(struct session_database *sdb, char *type) } else return -1; - yaz_log(YLOG_LOG, "Returned type %s", type); return 0; } - return -1; + else /* attempt to deduce structure */ + { + const char *syntax = ZOOM_record_get(rec, "syntax", NULL); + if (syntax) + { + if (!strcmp(syntax, "XML")) + { + strcpy(type, "xml"); + return 0; + } + else if (!strcmp(syntax, "USmarc") || !strcmp(syntax, "MARC21")) + { + strcpy(type, "xml; charset=marc8-s"); + return 0; + } + else return -1; + } + else return -1; + } } static void ingest_raw_record(struct client *cl, ZOOM_record rec) @@ -330,7 +322,7 @@ static void ingest_raw_record(struct client *cl, ZOOM_record rec) else { struct session_database *sdb = client_get_database(cl); - nativesyntax_to_type(sdb, type); + nativesyntax_to_type(sdb, type, rec); } buf = ZOOM_record_get(rec, type, &len); @@ -349,12 +341,13 @@ void client_search_response(struct client *cl) if (ZOOM_connection_error(link, &error, &addinfo)) { cl->hits = 0; - cl->state = Client_Error; + client_set_state(cl, Client_Error); yaz_log(YLOG_WARN, "Search error %s (%s): %s", error, addinfo, client_get_url(cl)); } else { + cl->record_offset = 0; cl->hits = ZOOM_resultset_size(resultset); se->total_hits += cl->hits; } @@ -368,10 +361,9 @@ void client_record_response(struct client *cl) ZOOM_resultset resultset = connection_get_resultset(co); const char *error, *addinfo; - yaz_log(YLOG_LOG, "client_record_response"); if (ZOOM_connection_error(link, &error, &addinfo)) { - cl->state = Client_Error; + client_set_state(cl, Client_Error); yaz_log(YLOG_WARN, "Search error %s (%s): %s", error, addinfo, client_get_url(cl)); } @@ -380,8 +372,6 @@ void client_record_response(struct client *cl) ZOOM_record rec = 0; const char *msg, *addinfo; - yaz_log(YLOG_LOG, "show_raw=%p show_raw->active=%d", - cl->show_raw, cl->show_raw ? cl->show_raw->active : 0); if (cl->show_raw && cl->show_raw->active) { if ((rec = ZOOM_resultset_record(resultset, @@ -390,27 +380,32 @@ void client_record_response(struct client *cl) cl->show_raw->active = 0; ingest_raw_record(cl, rec); } + else + { + yaz_log(YLOG_WARN, "Expected record, but got NULL, offset=%d", + cl->show_raw->position-1); + } } else { - int offset = cl->records; + int offset = cl->record_offset; if ((rec = ZOOM_resultset_record(resultset, offset))) { - yaz_log(YLOG_LOG, "Record with offset %d", offset); - - cl->records++; + cl->record_offset++; if (ZOOM_record_error(rec, &msg, &addinfo, 0)) yaz_log(YLOG_WARN, "Record error %s (%s): %s (rec #%d)", - error, addinfo, client_get_url(cl), cl->records); + error, addinfo, client_get_url(cl), + cl->record_offset); else { struct session_database *sdb = client_get_database(cl); const char *xmlrec; char type[80]; - nativesyntax_to_type(sdb, type); + if (nativesyntax_to_type(sdb, type, rec)) + yaz_log(YLOG_WARN, "Failed to determine record type"); if ((xmlrec = ZOOM_record_get(rec, type, NULL))) { - if (ingest_record(cl, xmlrec, cl->records)) + if (ingest_record(cl, xmlrec, cl->record_offset)) { session_alert_watch(cl->session, SESSION_WATCH_SHOW); session_alert_watch(cl->session, SESSION_WATCH_RECORD); @@ -423,9 +418,12 @@ void client_record_response(struct client *cl) } } + else + { + yaz_log(YLOG_WARN, "Expected record, but got NULL, offset=%d", + offset); + } } - if (!rec) - yaz_log(YLOG_WARN, "Expected record, but got NULL"); } } @@ -446,8 +444,9 @@ void client_start_search(struct client *cl) assert(link); cl->hits = -1; - cl->records = 0; + cl->record_offset = 0; cl->diagnostic = 0; + client_set_state(cl, Client_Working); if (*opt_piggyback) ZOOM_connection_option_set(link, "piggyback", opt_piggyback); @@ -469,20 +468,24 @@ void client_start_search(struct client *cl) sprintf(n, "%d", global_parameters.toget); ZOOM_connection_option_set(link, "count", n); } - if (!databaseName || !*databaseName) - databaseName = "Default"; - ZOOM_connection_option_set(link, "databaseName", databaseName); + if (databaseName) + ZOOM_connection_option_set(link, "databaseName", databaseName); ZOOM_connection_option_set(link, "presentChunk", "20"); if (cl->cqlquery) { + yaz_log(YLOG_LOG, "Search %s CQL: %s", sdb->database->url, cl->cqlquery); ZOOM_query q = ZOOM_query_create(); ZOOM_query_cql(q, cl->cqlquery); rs = ZOOM_connection_search(link, q); + ZOOM_query_destroy(q); } else + { + yaz_log(YLOG_LOG, "Search %s PQF: %s", sdb->database->url, cl->pquery); rs = ZOOM_connection_search_pqf(link, cl->pquery); + } connection_set_resultset(co, rs); connection_continue(co); } @@ -503,9 +506,7 @@ struct client *client_create(void) r->connection = 0; r->session = 0; r->hits = 0; - r->records = 0; - r->setno = 0; - r->requestid = -1; + r->record_offset = 0; r->diagnostic = 0; r->state = Client_Disconnected; r->show_raw = 0; @@ -596,7 +597,7 @@ static char *make_cqlquery(struct client *cl) yaz_log(YLOG_WARN, "failed to generate CQL query, code=%d", status); return 0; } - r = xstrdup(wrbuf_buf(wrb)); + r = xstrdup(wrbuf_cstr(wrb)); wrbuf_destroy(wrb); odr_reset(global_parameters.odr_out); // releases the zquery @@ -613,6 +614,7 @@ int client_parse_query(struct client *cl, const char *query) int cerror, cpos; CCL_bibset ccl_map = prepare_cclmap(cl); const char *sru = session_setting_oneval(sdb, PZ_SRU); + const char *pqf_prefix = session_setting_oneval(sdb, PZ_PQF_PREFIX); if (!ccl_map) return -1; @@ -621,12 +623,17 @@ int client_parse_query(struct client *cl, const char *query) ccl_qual_rm(&ccl_map); if (!cn) { - cl->state = Client_Error; + client_set_state(cl, Client_Error); yaz_log(YLOG_WARN, "Failed to parse query for %s", client_get_database(cl)->database->url); return -1; } wrbuf_rewind(se->wrbuf); + if (*pqf_prefix) + { + wrbuf_puts(se->wrbuf, pqf_prefix); + wrbuf_puts(se->wrbuf, " "); + } ccl_pquery(se->wrbuf, cn); xfree(cl->pquery); cl->pquery = xstrdup(wrbuf_cstr(se->wrbuf)); @@ -664,8 +671,7 @@ void client_set_session(struct client *cl, struct session *se) int client_is_active(struct client *cl) { - if (cl->connection && (cl->state == Client_Continue || - cl->state == Client_Connecting || + if (cl->connection && (cl->state == Client_Connecting || cl->state == Client_Working)) return 1; return 0; @@ -686,7 +692,7 @@ int client_get_hits(struct client *cl) int client_get_num_records(struct client *cl) { - return cl->records; + return cl->record_offset; } int client_get_diagnostic(struct client *cl)