X-Git-Url: http://jsfdemo.indexdata.com/?a=blobdiff_plain;f=src%2Fhttp_command.c;h=7676eef81e39c67a7285025b1d99717f7c02be70;hb=cbcac593e14143ef6b50a60f43204b53938a446d;hp=b75c9c90bad787182cbac342cae037471d418438;hpb=e81158e362e2c7c9e2fb8bce430dbe415c37ad87;p=pazpar2-moved-to-github.git
diff --git a/src/http_command.c b/src/http_command.c
index b75c9c9..7676eef 100644
--- a/src/http_command.c
+++ b/src/http_command.c
@@ -93,6 +93,16 @@ struct http_sessions {
static YAZ_MUTEX g_http_session_mutex = 0;
static int g_http_sessions = 0;
+int get_version(struct http_request *rq) {
+ const char *version = http_argbyname(rq, "version");
+ int version_no = 0;
+ if (version && strcmp(version, "")) {
+ version_no = atoi(version);
+ }
+ return version_no;
+}
+
+
int http_session_use(int delta)
{
int sessions;
@@ -460,6 +470,8 @@ static void cmd_init(struct http_channel *c)
wrbuf_puts(c->wrbuf, ""
"" PAZPAR2_PROTOCOL_VERSION "");
+ wrbuf_printf(c->wrbuf, "%d\n", 1000 * ((s->psession->service->session_timeout >= 20) ?
+ (s->psession->service->session_timeout - 10) : 50));
response_close(c, "init");
}
@@ -488,6 +500,7 @@ static void cmd_settings(struct http_channel *c)
{
xmlDoc *doc = xmlParseMemory(rq->content_buf, rq->content_len);
xmlNode *root_n;
+ int ret;
if (!doc)
{
error(rs, PAZPAR2_MALFORMED_SETTING, 0);
@@ -495,10 +508,14 @@ static void cmd_settings(struct http_channel *c)
return;
}
root_n = xmlDocGetRootElement(doc);
-
- settings_read_node_x(root_n, s->psession, apply_local_setting);
-
+ ret = settings_read_node_x(root_n, s->psession, apply_local_setting);
xmlFreeDoc(doc);
+ if (ret)
+ {
+ error(rs, PAZPAR2_MALFORMED_SETTING, 0);
+ release_session(c,s);
+ return;
+ }
}
if (process_settings(s->psession, rq, rs) < 0)
{
@@ -515,11 +532,7 @@ static void termlist_response(struct http_channel *c, struct http_session *s, co
struct http_request *rq = c->request;
const char *name = http_argbyname(rq, "name");
const char *nums = http_argbyname(rq, "num");
- const char *version = http_argbyname(rq, "version");
- int version_no = 0;
- if (version && strcmp(version, "")) {
- version_no = atoi(version);
- }
+ int version = get_version(rq);
int num = 15;
int status;
@@ -535,7 +548,7 @@ static void termlist_response(struct http_channel *c, struct http_session *s, co
}
wrbuf_printf(c->wrbuf, "%d\n", status);
- perform_termlist(c, s->psession, name, num, version_no);
+ perform_termlist(c, s->psession, name, num, version);
response_close(c, "termlist");
}
@@ -681,11 +694,7 @@ static void bytarget_response(struct http_channel *c, struct http_session *s, co
struct hitsbytarget *ht;
struct http_request *rq = c->request;
const char *settings = http_argbyname(rq, "settings");
- const char *protocol_version = http_argbyname(rq, "version");
- int version = 0;
- if (protocol_version && strcmp(protocol_version,"")) {
- version = atoi(protocol_version);
- }
+ int version = get_version(rq);
ht = get_hitsbytarget(s->psession, &count, c->nmem);
if (!cmd_status)
/* Old protocol, always ok */
@@ -724,8 +733,10 @@ static void bytarget_response(struct http_channel *c, struct http_session *s, co
}
wrbuf_printf(c->wrbuf, "%d\n", ht[i].records - ht[i].filtered);
- if (version >= 2)
+ if (version >= 2) {
wrbuf_printf(c->wrbuf, "%d\n", ht[i].filtered);
+ wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", ht[i].approximation);
+ }
wrbuf_puts(c->wrbuf, "");
wrbuf_xmlputs(c->wrbuf, ht[i].state);
wrbuf_puts(c->wrbuf, "\n");
@@ -864,10 +875,14 @@ static void write_subrecord(struct record *r, WRBUF w,
wrbuf_puts(w, "client));
- wrbuf_puts(w, "\" ");
+ wrbuf_puts(w, "\"\n");
- wrbuf_puts(w, "name=\"");
+ wrbuf_puts(w, " name=\"");
wrbuf_xmlputs(w, *name ? name : "Unknown");
+ wrbuf_puts(w, "\" ");
+
+ wrbuf_puts(w, "checksum=\"");
+ wrbuf_printf(w, "%u", r->checksum);
wrbuf_puts(w, "\">");
write_metadata(w, service, r->metadata, show_details);
@@ -928,11 +943,11 @@ static void show_record(struct http_channel *c, struct http_session *s)
struct http_response *rs = c->response;
struct http_request *rq = c->request;
struct record_cluster *rec, *prev_r, *next_r;
- struct record *r;
struct conf_service *service;
const char *idstr = http_argbyname(rq, "id");
const char *offsetstr = http_argbyname(rq, "offset");
const char *binarystr = http_argbyname(rq, "binary");
+ const char *checksumstr = http_argbyname(rq, "checksum");
if (!s)
return;
@@ -956,9 +971,8 @@ static void show_record(struct http_channel *c, struct http_session *s)
}
return;
}
- if (offsetstr)
+ if (offsetstr || checksumstr)
{
- int offset = atoi(offsetstr);
const char *syntax = http_argbyname(rq, "syntax");
const char *esn = http_argbyname(rq, "esn");
int i;
@@ -969,14 +983,25 @@ static void show_record(struct http_channel *c, struct http_session *s)
if (binarystr && *binarystr != '0')
binary = 1;
- for (i = 0; i < offset && r; r = r->next, i++)
- ;
- if (!r)
+ if (checksumstr)
{
- error(rs, PAZPAR2_RECORD_FAIL, "no record at offset given");
+ long v = atol(checksumstr);
+ for (i = 0; r; r = r->next)
+ if (v == r->checksum)
+ break;
+ if (!r)
+ error(rs, PAZPAR2_RECORD_FAIL, "no record");
}
else
{
+ int offset = atoi(offsetstr);
+ for (i = 0; i < offset && r; r = r->next, i++)
+ ;
+ if (!r)
+ error(rs, PAZPAR2_RECORD_FAIL, "no record at offset given");
+ }
+ if (r)
+ {
http_channel_observer_t obs =
http_add_observer(c, r->client, show_raw_reset);
int ret = client_show_raw_begin(r->client, r->position,
@@ -997,6 +1022,7 @@ static void show_record(struct http_channel *c, struct http_session *s)
}
else
{
+ struct record *r;
response_open_no_status(c, "record");
wrbuf_puts(c->wrbuf, "\n");
wrbuf_xmlputs(c->wrbuf, rec->recid);
@@ -1053,10 +1079,13 @@ static void show_records(struct http_channel *c, struct http_session *s, int act
const char *start = http_argbyname(rq, "start");
const char *num = http_argbyname(rq, "num");
const char *sort = http_argbyname(rq, "sort");
+ int version = get_version(rq);
+
int startn = 0;
int numn = 20;
int total;
Odr_int total_hits;
+ Odr_int approx_hits;
int i;
if (!s)
@@ -1079,12 +1108,15 @@ static void show_records(struct http_channel *c, struct http_session *s, int act
}
- rl = show_range_start(s->psession, sp, startn, &numn, &total, &total_hits);
+ rl = show_range_start(s->psession, sp, startn, &numn, &total, &total_hits, &approx_hits);
response_open(c, "show");
wrbuf_printf(c->wrbuf, "\n%d\n", active);
wrbuf_printf(c->wrbuf, "%d\n", total);
wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", total_hits);
+ if (version >= 2) {
+ wrbuf_printf(c->wrbuf, "" ODR_INT_PRINTF "\n", approx_hits);
+ }
wrbuf_printf(c->wrbuf, "%d\n", startn);
wrbuf_printf(c->wrbuf, "%d\n", numn);
@@ -1137,6 +1169,7 @@ static void cmd_show(struct http_channel *c)
const char *block = http_argbyname(rq, "block");
const char *sort = http_argbyname(rq, "sort");
const char *block_error = http_argbyname(rq, "report");
+
struct reclist_sortparms *sp;
int status;
int report_error = 0;
@@ -1155,7 +1188,9 @@ static void cmd_show(struct http_channel *c)
release_session(c, s);
return;
}
- session_sort(s->psession, sp->name, sp->increasing);
+ session_sort(s->psession, sp->name, sp->increasing, sp->type == Metadata_sortkey_position);
+ /* TODO This was too simple. Will make pazpar2 continuing reseting the session resultset and redo the search. Disable this for now
+ sp->type == Metadata_sortkey_position */
status = session_active_clients(s->psession);