X-Git-Url: http://jsfdemo.indexdata.com/?a=blobdiff_plain;f=src%2Freclists.c;h=738fdc481621d340533d4abc3949ec8d394840aa;hb=b4e80d145253134b44614896ba7f0b1975d22afa;hp=f41e5735c0411624ff1a421bdd76297f46a1574d;hpb=d4be799aeb5470d5c855624c13d06d55787981c5;p=pazpar2-moved-to-github.git

diff --git a/src/reclists.c b/src/reclists.c
index f41e573..738fdc4 100644
--- a/src/reclists.c
+++ b/src/reclists.c
@@ -1,4 +1,4 @@
-/* $Id: reclists.c,v 1.16 2007-05-01 05:02:54 quinn Exp $
+/* $Id: reclists.c,v 1.23 2007-09-10 16:25:50 adam Exp $
    Copyright (c) 2006-2007, Index Data.
 
 This file is part of Pazpar2.
@@ -41,6 +41,7 @@ struct reclist_bucket
     struct reclist_bucket *next;
 };
 
+#if 0
 struct reclist_sortparms * 
 reclist_sortparms_insert_field_id(NMEM nmem,
                          struct reclist_sortparms **sortparms,
@@ -67,8 +68,9 @@ reclist_sortparms_insert_field_id(NMEM nmem,
 
     return *sortparms;
 };
+#endif
 
-
+#if 0
 struct reclist_sortparms * 
 reclist_sortparms_insert(NMEM nmem, 
                          struct reclist_sortparms **sortparms,
@@ -90,7 +92,7 @@ reclist_sortparms_insert(NMEM nmem,
                                              service->sortkeys[field_id].type,
                                              increasing);
 };
-
+#endif
 
 
 struct reclist_sortparms *reclist_parse_sortparms(NMEM nmem, const char *parms)
@@ -108,7 +110,7 @@ struct reclist_sortparms *reclist_parse_sortparms(NMEM nmem, const char *parms)
         const char *cpp;
         int increasing;
         int i;
-        int offset;
+        int offset = 0;
         enum conf_sortkey_type type;
         struct reclist_sortparms *new;
 
@@ -127,7 +129,6 @@ struct reclist_sortparms *reclist_parse_sortparms(NMEM nmem, const char *parms)
         if (!strcmp(parm, "relevance"))
         {
             type = Metadata_sortkey_relevance;
-            offset = -1;
         }
         else
         {
@@ -167,37 +168,50 @@ static int reclist_cmp(const void *p1, const void *p2)
     struct record_cluster *r1 = (*(struct record_cluster**) p1);
     struct record_cluster *r2 = (*(struct record_cluster**) p2);
     struct reclist_sortparms *s;
+    int res = 0;
 
-    for (s = sortparms; s; s = s->next)
+    for (s = sortparms; s && res == 0; s = s->next)
     {
-        int res;
+        union data_types *ut1 = r1->sortkeys[s->offset];
+        union data_types *ut2 = r2->sortkeys[s->offset];
         switch (s->type)
         {
-            char *s1, *s2;
+            const char *s1, *s2;
             
             case Metadata_sortkey_relevance:
                 res = r2->relevance - r1->relevance;
                 break;
             case Metadata_sortkey_string:
-                s1 = r1->sortkeys[s->offset] ? r1->sortkeys[s->offset]->text : "";
-                s2 = r2->sortkeys[s->offset] ? r2->sortkeys[s->offset]->text : "";
+                s1 = ut1 ? ut1->text.sort : "";
+                s2 = ut2 ? ut2->text.sort : "";
                 res = strcmp(s2, s1);
+                if (res)
+                {
+                    if (s->increasing)
+                        res *= -1;
+                }
                 break;
             case Metadata_sortkey_numeric:
-                res = 0;
+                if (ut1 && ut2)
+                {
+                    if (s->increasing)
+                        res = ut1->number.min  - ut2->number.min;
+                    else
+                        res = ut2->number.max  - ut1->number.max;
+                }
+                else if (ut1 && !ut2)
+                    res = -1;
+                else if (!ut1 && ut2)
+                    res = 1;
+                else
+                    res = 0;
                 break;
             default:
-                yaz_log(YLOG_FATAL, "Bad sort type: %d", s->type);
-                exit(1);
-        }
-        if (res)
-        {
-            if (s->increasing)
-                res *= -1;
-            return res;
+                yaz_log(YLOG_WARN, "Bad sort type: %d", s->type);
+                res = 0;
         }
     }
-    return 0;
+    return res;
 }
 
 void reclist_sort(struct reclist *l, struct reclist_sortparms *parms)
@@ -210,7 +224,7 @@ void reclist_sort(struct reclist *l, struct reclist_sortparms *parms)
 
 struct record_cluster *reclist_read_record(struct reclist *l)
 {
-    if (l->pointer < l->num_records)
+    if (l && l->pointer < l->num_records)
         return l->flatlist[l->pointer++];
     else
         return 0;
@@ -218,7 +232,8 @@ struct record_cluster *reclist_read_record(struct reclist *l)
 
 void reclist_rewind(struct reclist *l)
 {
-    l->pointer = 0;
+    if (l)
+        l->pointer = 0;
 }
 
 // Jenkins one-at-a-time hash (from wikipedia)
@@ -265,7 +280,7 @@ struct reclist *reclist_create(NMEM nmem, int numrecs)
 struct record_cluster *reclist_insert( struct reclist *l,
                                        struct conf_service *service, 
                                        struct record  *record,
-                                       const char *merge_key, int *total)
+                                       char *merge_key, int *total)
 {
     unsigned int bucket;
     struct reclist_bucket **p;
@@ -302,10 +317,11 @@ struct record_cluster *reclist_insert( struct reclist *l,
         new->record = newc;
         new->next = 0;
         newc->records = record;
-        newc->merge_key = (char *) merge_key;
+        newc->merge_key = merge_key;
         newc->relevance = 0;
         newc->term_frequency_vec = 0;
-        newc->recid = (*total)++;
+        newc->recid = merge_key;
+        (*total)++;
         newc->metadata = nmem_malloc(l->nmem,
                 sizeof(struct record_metadata*) * service->num_metadata);
         memset(newc->metadata, 0,