From 2caa42f8fcdbf463e7f8e94a9a9b9c578ffc2926 Mon Sep 17 00:00:00 2001
From: Jakub Skoczen <jakub@indexdata.dk>
Date: Wed, 5 May 2010 16:57:03 +0200
Subject: [PATCH] Implement iterable on result set

Add docs and change getRecord(int) to getRecord(long)
---
 src/main/java/org/yaz4j/ResultSet.java |   50 ++++++++++++++++++++++++++++++--
 src/test/org/yaz4j/ConnectionTest.java |    9 ++++++
 2 files changed, 57 insertions(+), 2 deletions(-)

diff --git a/src/main/java/org/yaz4j/ResultSet.java b/src/main/java/org/yaz4j/ResultSet.java
index ab3af1a..766b998 100644
--- a/src/main/java/org/yaz4j/ResultSet.java
+++ b/src/main/java/org/yaz4j/ResultSet.java
@@ -1,11 +1,32 @@
 package org.yaz4j;
 
+import java.util.Iterator;
+import java.util.NoSuchElementException;
 import org.yaz4j.exception.ZoomException;
 import org.yaz4j.jni.SWIGTYPE_p_ZOOM_record_p;
 import org.yaz4j.jni.SWIGTYPE_p_ZOOM_resultset_p;
 import org.yaz4j.jni.yaz4jlib;
 
-public class ResultSet {
+/**
+ * This class represents a "buffered handle" to the result set created on the
+ * server and thus retrieving records may invlove a request to the server if
+ * those records are not locally cached. Details on how to configure the retrieval
+ * (present) process are available in the YAZ manual
+ *
+ * @see <a href="http://www.indexdata.com/yaz/doc/zoom.resultsets.html">YAZ ZOOM result sets</a>
+ *
+ * Becacuse of the server misbehaviour or errors during retrieval the
+ * "getRecord" method may either return null or throw exceptions, even when the
+ * index of retrieved records lies within the bounds of the set. Client
+ * code should be prepared for such situations.
+ *
+ * This class implements the iterable interface and as such can be used within
+ * foreach loops, it's important to note however that in this case the errors
+ * during retrieval will be masked with standard NoSuchElementExceptions
+ *
+ * @author jakub
+ */
+public class ResultSet implements Iterable<Record> {
   //for GC refcount
 
   private Connection conn;
@@ -44,7 +65,7 @@ public class ResultSet {
     return this;
   }
 
-  public Record getRecord(int index) throws ZoomException {
+  public Record getRecord(long index) throws ZoomException {
     SWIGTYPE_p_ZOOM_record_p record =
       yaz4jlib.ZOOM_resultset_record(resultSet, index);
     //may be out of range or unsupported syntax
@@ -58,6 +79,31 @@ public class ResultSet {
     return new Record(record, this);
   }
 
+  @Override
+  public Iterator<Record> iterator() {
+    return new Iterator<Record>() {
+      private long cur;
+      @Override
+      public boolean hasNext() {
+        return cur < size;
+      }
+
+      @Override
+      public Record next() {
+        try {
+          return getRecord(cur++);
+        } catch (ZoomException ze) {
+          throw new NoSuchElementException(ze.getMessage());
+        }
+      }
+
+      @Override
+      public void remove() {
+        throw new UnsupportedOperationException("remove operation not supported");
+      }
+    };
+  }
+
   public long getHitCount() {
     return size;
   }
diff --git a/src/test/org/yaz4j/ConnectionTest.java b/src/test/org/yaz4j/ConnectionTest.java
index abeca8f..e577707 100644
--- a/src/test/org/yaz4j/ConnectionTest.java
+++ b/src/test/org/yaz4j/ConnectionTest.java
@@ -27,6 +27,14 @@ public class ConnectionTest {
       assertEquals(content[0], 103);
       assertEquals(rec.getSyntax(), "SUTRS");
       assertEquals(rec.getDatabase(), "gils");
+      System.out.println("Read all records..");
+      // read all records
+      int i = 0;
+      for (Record r : s) {
+        assertNotNull(r);
+        System.out.println("Got "+i+" record of type "+r.getSyntax());
+        i++;
+      }
     } catch (ZoomException ze) {
       fail(ze.getMessage());
     } finally {
@@ -34,6 +42,7 @@ public class ConnectionTest {
     }
   }
 
+
   @Test
   public void unsupportedSyntax() {
     System.out.println("Open connection to z3950.loc.gov:7090/voyager...");
-- 
1.7.10.4